Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skip submodules flag #5406

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 6, 2019

Now we have a way of skip submodules
(using a configuration file).
We should notify users that have a feature flag to migrate.

Now we have a way of skip submodules
(using a configuration file).
We should notify users that have a feature flag to migrate.
@stsewd stsewd requested a review from Mar 6, 2019
@humitos
Copy link
Member

@humitos humitos commented Mar 6, 2019

We should notify users that have a feature flag to migrate.

We should do this before merging this PR and give them some time to make the migration. After that, we can merge and deploy, I'd say. Otherwise, we will break their builds automatically once this gets deployed.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 11, 2019

Blocking this till all users using the flag have migrated to a config file.

@humitos
Copy link
Member

@humitos humitos commented Apr 2, 2019

Blocking this till all users using the flag have migrated to a config file.

I'm not sure we will ever know this. I suppose we can close this PR that will be open forever otherwise and revisit it once we have deprecated Config V1.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Apr 2, 2019

I'm not sure we will ever know this.

We know what projects are using the skip_submodules flag, we have to notify them

@humitos
Copy link
Member

@humitos humitos commented Apr 3, 2019

Oh! Forget what I said. I misread the comments. You are right.

@stsewd
Copy link
Member Author

@stsewd stsewd commented May 1, 2019

We have 6 projects in .org: amara, chassis, firesim, qwat, rematch, u-bmc

Not sure how to proceed, and how many we have in .com :)

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 2, 2019

@stsewd we need to contact them all and help them move to the YAML file. We could even go as far as submitting a PR for their repo with a proper config, if we wanted (especially if we had a PR builder :D)

@humitos
Copy link
Member

@humitos humitos commented May 20, 2019

We only have 6 projects using this feature flag, so contacting them or making a PR on their repo is affordable if we want to go faster. @stsewd feel free to do the one you like most ;)

@stsewd
Copy link
Member Author

@stsewd stsewd commented May 20, 2019

@humitos I'm more worried about user using this in the corporate site, we need to inform those users too.

@humitos humitos added this to the Cleanup milestone Jun 10, 2019
@humitos
Copy link
Member

@humitos humitos commented Jul 9, 2019

I'm about to contact these users to let them know how to upgrade their projects to keep building properly.

@humitos
Copy link
Member

@humitos humitos commented Jul 9, 2019

/remind me to polish this PR and try to merge in 7 weeks

after all the users have implemented the Config File V2 with the exclude option.

@humitos
Copy link
Member

@humitos humitos commented Aug 6, 2019

Unblocking this issue.

All the users were notified and most of them replied in time communicating that they already did the required change in their YAML files.

We are ready to merge this PR once the conflicts are resolved and deploy.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Aug 7, 2019

@humitos done

humitos
humitos approved these changes Aug 7, 2019
@ericholscher ericholscher merged commit 6767b16 into readthedocs:master Aug 7, 2019
1 check passed
@stsewd stsewd deleted the remove-submodules-flag branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants