Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation guide to include submodules #5416

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@agarwalrounak
Copy link
Contributor

@agarwalrounak agarwalrounak commented Mar 7, 2019

Fixes #5408
The clone step in the installation guide is updated to include submodules.

Copy link
Member

@stsewd stsewd left a comment

Thanks, but we can just use the --recurse-submodules option in the clone step.

https://www.git-scm.com/docs/git-clone#git-clone---recurse-submodulesltpathspec

@agarwalrounak
Copy link
Contributor Author

@agarwalrounak agarwalrounak commented Mar 7, 2019

Thanks for the review, learned a new thing today.

docs/install.rst Outdated Show resolved Hide resolved
Update installation guide to include submodules

Update installation guide to include submodules
stsewd
stsewd approved these changes Mar 7, 2019
Copy link
Member

@stsewd stsewd left a comment

Thanks!

@agarwalrounak
Copy link
Contributor Author

@agarwalrounak agarwalrounak commented Mar 7, 2019

Can you please take a look at PR #5411

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 7, 2019

Tests need to pass first before any review

@stsewd stsewd merged commit 78c34c9 into readthedocs:master Mar 7, 2019
1 check passed
@agarwalrounak agarwalrounak deleted the submodule branch Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants