Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reraise of exception #5423

Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 8, 2019

We were hiding the real error
from the user

Related #4745 (comment)

We were hiding the real error
from the user

Related readthedocs#4745 (comment)
@stsewd stsewd requested a review from Mar 8, 2019
Copy link
Member

@ericholscher ericholscher left a comment

I don't fully understand what this was doing before. It looks like we don't use this with_traceback pattern anywhere else, so seems good to remove it.

@ericholscher ericholscher merged commit 61db3c1 into readthedocs:master Mar 14, 2019
1 check passed
@stsewd stsewd deleted the fix-exception-configpy-not-found branch Mar 14, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 14, 2019

We were catching a general ProjectConfigurationError execption and re-raising the error with a different message but with the same type 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants