Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused form #5443

Merged
merged 4 commits into from May 20, 2019
Merged

Remove unused form #5443

merged 4 commits into from May 20, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 13, 2019

We never finished this feature, but is coming soon!

There are more to remove, but I need to investigate is we are still using some the UPLOAD_ROOT setting and the uploaded fields from the version model,

Added in c33c84d

We never finished this feature, but is coming soon!
@stsewd stsewd added this to the Cleanup milestone Mar 13, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 14, 2019

We need to check if we have projects with versions uploaded=True, if not, we can remove that field.

@humitos
Copy link
Member

@humitos humitos commented Mar 25, 2019

We need to check if we have projects with versions uploaded=True, if not, we can remove that field.

We have 113 version with uploaded=True (80 projects in total). Although, I don't think this is used anywhere in the code and could be removed. We can merge this PR and decide what to do with them later, though.

@stale
Copy link

@stale stale bot commented May 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale label May 9, 2019
@humitos
Copy link
Member

@humitos humitos commented May 9, 2019

@stsewd we should close this PR or finish and merge it.

We could also mark it as "Good First Issue" asking the community to finish it on the other hand if we can tackle it now.

@stale stale bot removed the Status: stale label May 9, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented May 9, 2019

We can merge this and have another PR to remove the upload field and setting.

Copy link
Member

@humitos humitos left a comment

Let's merge it!

@humitos humitos merged commit 30715a3 into readthedocs:master May 20, 2019
1 check passed
@stsewd stsewd deleted the remove-unused-form branch May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants