Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of setuptools #5450

Merged
merged 1 commit into from Mar 18, 2019
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 13, 2019

the 40.x releases has a lot of bugfixes and compatibility changes
to support the latest version of pip, which we install by default now.

Changelog https://setuptools.readthedocs.io/en/latest/history.html#v40-8-0

Closes #5436

the 40.x releases has a lot of bugfixes and compatibility changes
to support the latest version of pip, which we install by default now.

Closes readthedocs#5436
@stsewd stsewd requested a review from Mar 13, 2019
Copy link
Member

@humitos humitos left a comment

I don't have too much experience upgrading this package on RTD, but I think it's safe.

Now, both positive and negative will return the same value. Is that OK?

Besides, since we are modifying the negative value, this will affect all the builds not only the ones that have the feature flag.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 13, 2019

Now, both positive and negative will return the same value. Is that OK?

There isn't a 41.x release. I can just drop the flag and use only one version, but I left it just to be clear that we experiment with that package.

Copy link
Member

@ericholscher ericholscher left a comment

Seems fine to me. A bit silly to have both values return the same, but fine for now, especially if we want to use it again in the future.

@ericholscher ericholscher merged commit 56a26f5 into readthedocs:master Mar 18, 2019
1 check passed
@stsewd stsewd deleted the update-setuptools branch Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants