Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in footer links #5454

Merged
merged 2 commits into from Mar 13, 2019

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Mar 13, 2019

Closes #5449

@@ -151,19 +151,19 @@ <h4>{% trans 'Get Involved' %}</h4>

<ul>
<li>
<a href="https://docs.readthedocs.io/en/latest/getting_started.html">{% trans 'Getting Started Guide' %}</a>
<a href="https://docs.readthedocs.io/page/getting_started.html">{% trans 'Getting Started Guide' %}</a>
Copy link
Member

@stsewd stsewd Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this page redirects to /intro/getting-started-with-sphinx.html

Loading

Copy link
Member Author

@dojutsu-user dojutsu-user Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed the changes.
Thanks.

Loading

stsewd
stsewd approved these changes Mar 13, 2019
Copy link
Member

@stsewd stsewd left a comment

Thanks

Loading

Copy link
Contributor

@davidfischer davidfischer left a comment

This looks good to me too.

I think there are some additional templates where we could do the same throughout the repository if you're feeling ambitious!

Loading

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Mar 13, 2019

@davidfischer
I would like to update this. There are many places where the link is pointed to latest version.
Will update this PR to point them at stable version.

Loading

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 13, 2019

@dojutsu-user please open a new PR, so it's easy to review, I'm merging this one.

Loading

@stsewd stsewd merged commit 8607c7e into readthedocs:master Mar 13, 2019
1 check passed
Loading
@dojutsu-user dojutsu-user deleted the consistency-in-links branch Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants