Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Django Debug Toolbar in development #5464

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 15, 2019

In the past few days I have found a few performance issues that could have been caught easier with Django Debug Toolbar (#5451 and #5460). I propose we enable it in development.

@@ -95,3 +95,6 @@ django-cors-middleware==1.3.1

# User agent parsing - used for analytics purposes
user-agents<1.2.0

# Required only in development and linting
django-debug-toolbar==1.11
Copy link
Member

@stsewd stsewd Mar 18, 2019

I think we should put this in another file like https://github.com/stsewd/readthedocs.org/blob/b856e791b6be6cff68a98efd1422f30136c2d856/requirements/testing.txt#L27-L29? Mostly because this will be installed in production too, we are not going to activate it, but looks like a dead package to have.

Copy link
Contributor Author

@davidfischer davidfischer Mar 18, 2019

The reason I put it here is that it is required for testing, development, and linting. Currently only the default requirements.txt file (which then loads pip.txt) is used in development according to our documentation.

stsewd
stsewd approved these changes Mar 18, 2019
Copy link
Member

@stsewd stsewd left a comment

My comment can be addressed in another PR if considered, I'll like to try this now :)

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Mar 18, 2019

I'm going to merge this now, but I think @stsewd's comment is a fair one. Overall, I think we need to be very clear what each of our requirements files are for. We also might have 1-2 too many requirements files (maybe just dev, test, and prod?). These are issues for another PR though.

@davidfischer davidfischer merged commit 724c6cb into master Mar 18, 2019
1 check passed
@davidfischer davidfischer deleted the davidfischer/debug-toolbar branch Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants