Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old/deprecated build endpoints #5479

Merged
merged 1 commit into from Jun 10, 2019
Merged

Conversation

@humitos
Copy link
Member

@humitos humitos commented Mar 18, 2019

We already communicated this to users in different opportunities when we GitHub deprecated GitHub Services. I think it's safe to finally remove them completely.

Closes #5057

@humitos humitos force-pushed the humitos/remove-deprecated-webhooks branch from 176542f to 779cf7b Mar 18, 2019
Copy link
Member

@stsewd stsewd left a comment

def _allow_deprecated_webhook(project):
return project.has_feature(Feature.ALLOW_DEPRECATED_WEBHOOKS)


def _build_version(project, slug, already_built=()):
Copy link
Member

@stsewd stsewd Mar 18, 2019

We can move this to another file later I guess

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 22, 2019

This is another place where I'd like to do a "brown out" before we remove the code completely, so users can yell if we break too much. Let's do an ops PR that removes these URL's with a warning, and then we can merge this after we've shipped that, if we don't hear much from users.

@humitos humitos force-pushed the humitos/remove-deprecated-webhooks branch from 779cf7b to 3c1c5ba Jun 6, 2019
@humitos
Copy link
Member Author

@humitos humitos commented Jun 6, 2019

I updated the PR to resolve the conflicts.

The PR that return an error at NGINX level was deployed 7 days ago and it's properly returning 410 Gone. I'm unblocking this PR and calling for review again. It could probably be merged and deployed in the next deploy --or we can wait more if we think it's needed.

Copy link
Member

@ericholscher ericholscher left a comment

Yay deleting code.

@humitos humitos merged commit a215295 into master Jun 10, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the humitos/remove-deprecated-webhooks branch Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants