Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch specific exception for config not found #5510

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 20, 2019

Create a config file for the user only when we
don't have one and don't hide the syntax error
to the user.

Fixes #5506
Fixes #5439

The error is show like this

Screenshot_2019-03-20 testfixtures Read the Docs

Create a config file for the user only when we
don't have one and don't hide the syntax error
to the user.

Fixes readthedocs#5506
@humitos
Copy link
Member

@humitos humitos commented Mar 21, 2019

Is the screenshot you shown here the new way to show this error? Looks a little cryptic to me. We should probably show something more user friendly.

Copy link
Member

@ericholscher ericholscher left a comment

Looks good 👍

readthedocs/doc_builder/config.py Show resolved Hide resolved
@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 21, 2019

Looks a little cryptic to me. We should probably show something more user friendly.

@humitos that comes from the yaml lib, not sure we can do something about that.

@stsewd stsewd merged commit 4263c14 into readthedocs:master Mar 21, 2019
1 check passed
@stsewd stsewd deleted the show-syntax-errors-to-users branch Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants