Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up grammar, promote Unicode characters #5511

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Mar 20, 2019

  • improves grammar and narrative for clarity and brevity
  • moves a link closer to its paragraph
  • explicitly cites Unicode characters as a potential build failure
  • s/configurations/settings (a configuration is a collection of settings)
- improves grammar and narrative for clarity and brevity
- moves a link closer to its paragraph
- explicitly cites Unicode characters as a potential build failure
stsewd
stsewd approved these changes Mar 21, 2019
Copy link
Member

@stsewd stsewd left a comment

Thanks! Looks great!

@stsewd stsewd requested a review from Mar 21, 2019
@stsewd stsewd merged commit 0464a5e into readthedocs:master Mar 21, 2019
1 check passed
@humitos
Copy link
Member

@humitos humitos commented Mar 21, 2019

Wow! Thanks @stevepiercy! You improved my broken English a lot :)

@stevepiercy stevepiercy deleted the patch-3 branch Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants