Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra origin in urls #5523

Merged
merged 10 commits into from Mar 27, 2019
Merged

Fix extra origin in urls #5523

merged 10 commits into from Mar 27, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 22, 2019

verbose_name is unique in each project, because we only have one remote.
identifier includes origin for branches and also it can point to the
same commit in tags.

Fixes #5518

`verbose_name` is unique in each project, because we only have one remote.
`identifier` includes origin for branches and also it can point to the
same commit in tags.

Fixes readthedocs#5518
@stsewd stsewd requested a review from Mar 22, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 22, 2019

Looks like this is going to need a little more of work, the cases of stable and latest don't work with verbose_name. We need to use https://github.com/rtfd/readthedocs.org/blob/e84bc96c2fe9f7b04832d9210f2a3026fb4a5b7b/readthedocs/builds/models.py#L150-L173

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 25, 2019

This is ready for review

@stsewd stsewd requested a review from ericholscher Mar 27, 2019
@stsewd stsewd merged commit 5f78337 into readthedocs:master Mar 27, 2019
1 check passed
@stsewd stsewd deleted the fix-extra-origin-urls branch Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants