Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Default branch: latest" does not exist Fix. #5547

Merged
merged 5 commits into from Apr 27, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Mar 28, 2019

closes #5390

@@ -246,7 +246,7 @@ def __init__(self, *args, **kwargs):
# the special cases of LATEST and STABLE.
all_versions_choices = [
(v.commit_name, v.verbose_name)
Copy link
Member

@stsewd stsewd Mar 28, 2019

We can use verbose_name for the id too now (commit_name was used only for the special cases of latest and stable). Also, we should add a test when the user has a version named latest or stable. Using commit_name will make the test fail.

Something like 82944ca

Copy link
Member Author

@saadmk11 saadmk11 Mar 28, 2019

Okay I'll Update the PR accordingly. 👍

Copy link
Member Author

@saadmk11 saadmk11 Mar 28, 2019

@stsewd What did you actually mean by this can you please clarify?

Using commit_name will make the test fail.

Copy link
Member

@stsewd stsewd Mar 28, 2019

If you write a test with a tag named latest or stable the current implementation will fail.

Copy link
Member

@stsewd stsewd Mar 28, 2019

I mean, a version created by the user machine=False

Copy link
Member Author

@saadmk11 saadmk11 Mar 29, 2019

@stsewd Updated the changes. but I'm Not sure I correctly understood what you meant about the tests. please have a look and let me know.

privacy_level=PUBLIC,
identifier='ab96cbff71a8f40a4240aaf9d12e6c10',
verbose_name='stable',
)
Copy link
Member

@stsewd stsewd Apr 1, 2019

Creating a version named stable is a specific test, we shouldn't merge it with the rest.

Copy link
Member Author

@saadmk11 saadmk11 Apr 2, 2019

@stsewd Okay 👍 . Updated the PR

stsewd
stsewd approved these changes Apr 3, 2019
Copy link
Member

@stsewd stsewd left a comment

Tests are more explicit now, thanks

@saadmk11
Copy link
Member Author

@saadmk11 saadmk11 commented Apr 3, 2019

@stsewd Thanks for helping me. It was a Great Experience :)

@stsewd stsewd requested a review from Apr 8, 2019
Copy link
Member

@humitos humitos left a comment

Thanks!

@humitos humitos merged commit 537f7b8 into readthedocs:master Apr 27, 2019
1 check passed
@saadmk11 saadmk11 deleted the default-branch-fix branch Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants