Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note in YAML docs #5565

Merged
merged 2 commits into from Apr 24, 2019
Merged

Added note in YAML docs #5565

merged 2 commits into from Apr 24, 2019

Conversation

@rshrc
Copy link
Contributor

@rshrc rshrc commented Apr 3, 2019

The note mentions that PDF\EPub is not supported when using Mkdocs

The note mentions that PDF\EPub is not supported when using Mkdocs
@rshrc
Copy link
Contributor Author

@rshrc rshrc commented Apr 3, 2019

closes #5561

Copy link
Member

@humitos humitos left a comment

Changes look good to me.

Can you check other places in the documentation where we mention these formats to check if it's needed to add a note as well there?

@@ -88,6 +88,10 @@ Example:
# Build all formats
formats: all
.. note::

PDF/epub output is not supported when using MkDocs
Copy link
Member

@humitos humitos Apr 3, 2019

I think that htmlzip is not supported as well. Can you confirm this?

Copy link
Contributor Author

@rshrc rshrc Apr 3, 2019

yupp, on it

@@ -88,6 +88,10 @@ Example:
# Build all formats
formats: all
.. note::

PDF/epub output is not supported when using MkDocs
Copy link
Member

@stsewd stsewd Apr 3, 2019

Actually htmlzip is not available either, we should put something like downloads are not currently supported for mkdocs or something like that

Copy link
Contributor Author

@rshrc rshrc Apr 3, 2019

got it

Copy link
Contributor Author

@rshrc rshrc Apr 3, 2019

I've currently added htmlzip to the note

Since htmlzip is also not available for mkdocs output, it was also added to the note
stsewd
stsewd approved these changes Apr 13, 2019
@stsewd stsewd requested a review from Apr 13, 2019
@ericholscher ericholscher merged commit 3058364 into readthedocs:master Apr 24, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants