Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non mobile fixed footer ads #5567

Merged
merged 2 commits into from Apr 3, 2019
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 3, 2019

This allows (but doesn't mandate) fixed footer text-only advertisements. The plan is to roll these out as a test to see if users react to them (do they perform? do users hate them?).

  • For starters, we'll roll them out on our docs only followed by community ads
  • As they expand perhaps they can target themes that previously didn't have ads or on docs where ads are either all the way at the bottom of the page (never viewed) or have a long sidebar (again, the ad isn't viewed)

image

@davidfischer davidfischer requested a review from Apr 3, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

@ericholscher ericholscher merged commit 511741c into master Apr 3, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/non-mobile-fixed-footer branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants