Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Firefox to close the ad correctly #5571

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 4, 2019

Firefox handles <a href="javascript:"> links differently.

@davidfischer davidfischer requested a review from Apr 4, 2019
humitos
humitos approved these changes Apr 4, 2019
@humitos
Copy link
Member

@humitos humitos commented Apr 4, 2019

I didn't really tested it but looks accurate.

@ericholscher ericholscher merged commit 4fea14e into master Apr 8, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/ad-close-fix-firefox branch Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants