Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove USE_SETUPTOOLS_LATEST feature flag #5578

Merged
merged 1 commit into from Apr 29, 2019
Merged

Conversation

@humitos
Copy link
Member

@humitos humitos commented Apr 8, 2019

This is not tested yet.

We should test that a couple of the projects with this feature in production builds locally when using setuptools==41 and we can deploy it after that I suppose.

stsewd
stsewd approved these changes Apr 8, 2019
@stsewd
Copy link
Member

@stsewd stsewd commented Apr 8, 2019

I'm guessing we already have some projects with this flag enabled

@humitos
Copy link
Member Author

@humitos humitos commented Apr 10, 2019

Actually, we do have ~10k projects with this feature flag.

Currently, all of our projects are building with setuptools<41. So, we may want to remove this feature flag from these ~10k (since we know they are building properly now --at least nobody reported anything related) and start from scratch with this: no projects marked to use the latest release. @ericholscher what do you think?

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 11, 2019

I think we should remove it -- it was something we were going to test, but I don't think we really ever did anything real with it.

@humitos humitos force-pushed the humitos/use-latest-setuptools branch from 695c162 to b69007d Apr 25, 2019
@humitos humitos changed the title Use <42 if project has USE_SETUPTOOLS_LATEST feature Remove USE_SETUPTOOLS_LATEST feature flag Apr 25, 2019
@humitos
Copy link
Member Author

@humitos humitos commented Apr 25, 2019

I removed the feature flag completely and default to setuptools==41.0.1. This is ready to re-review and merge probably.

@humitos humitos requested a review from Apr 25, 2019
stsewd
stsewd approved these changes Apr 25, 2019
@humitos humitos merged commit fc40907 into master Apr 29, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the humitos/use-latest-setuptools branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants