Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use downloads.html in template #5579

Merged
merged 1 commit into from Apr 8, 2019
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Apr 8, 2019

In #5502 we refactored the function
but we used to depend on pretty to change the name of the key from
html to htmlzip, we use html in the footer and in the theme.

So, it's safe to change the value in the template.

See https://github.com/rtfd/readthedocs.org/pull/5502/files#r272787188

In readthedocs#5502 we refactored the function
but we used to depend on `pretty` to change the name of the key from
`html` to `htmlzip`, we use `html` in the footer and in the theme.

So, it's safe to change the value in the template.

See https://github.com/rtfd/readthedocs.org/pull/5502/files#r272787188
Copy link
Member

@ericholscher ericholscher left a comment

Makes sense. 👍

@stsewd stsewd merged commit 7fa9002 into readthedocs:master Apr 8, 2019
1 check passed
@stsewd stsewd deleted the use-html-in-template branch Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants