Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 401, 403 and 404 when setting up webhooks #5589

Merged
merged 1 commit into from May 1, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Apr 13, 2019

Instead of doing it Like this I propose having a method (create_webhook) to handle webhook creation for Github, Gitlab and Bitbucket. The method might contain something like this:

https://github.com/rtfd/readthedocs.org/blob/b356689f26f380c38dcec828fd256d17b86ec849/readthedocs/oauth/services/bitbucket.py#L233-L249

closes #5092

stsewd
stsewd approved these changes Apr 13, 2019
Copy link
Member

@stsewd stsewd left a comment

I think this is good enough, just linking to a comment to the related issue (private repo) readthedocs/readthedocs-corporate#372 (comment)

@stsewd stsewd requested a review from Apr 23, 2019
@stsewd stsewd merged commit 77ef333 into readthedocs:master May 1, 2019
1 check passed
@saadmk11 saadmk11 deleted the handle-webhook-errors branch May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants