Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gold project sponsorship changes #5628

Merged
merged 2 commits into from May 10, 2019
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 24, 2019

  • new gold users can no longer sponsor projects
  • applies to gold users created after 2019-05-01
- new gold users can no longer sponsor projects
- applies to gold users created after 2019-05-01
@davidfischer davidfischer requested a review from Apr 24, 2019
@stsewd
Copy link
Member

@stsewd stsewd commented Apr 24, 2019

Shouldn't we use a time based feature flag for this?

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Apr 25, 2019

Shouldn't we use a time based feature flag for this?

Feature flags apply to projects, correct? This applies to the user subscription.

Copy link
Member

@humitos humitos left a comment

Looks good to me.

I left a comment about the message. Although, it's not a blocker on the PR. We can make the change later if we think it's better.

<p class="empty">
{% blocktrans trimmed %}
<strong>Note:</strong> this is a legacy feature.
New gold members cannot sponsor projects to be ad-free.
Copy link
Member

@humitos humitos Apr 25, 2019

It doesn't feel good to me to expose this to new gold users.

I'm not sure what's best here, but maybe removing this page completely for new gold users is better, instead of showing them that they could have sponsored their projects.

Copy link
Member

@ericholscher ericholscher Apr 25, 2019

I'm on the fence about whether to include it, but I do think we should probably prompt them to email us here about removing ads if they want as well. Or perhaps some other messaging?

Copy link
Contributor Author

@davidfischer davidfischer Apr 25, 2019

It doesn't feel good to me to expose this to new gold users.

The page is removed for new gold users. New users will be redirected. This message is shown only to older gold users to let them know that we no longer do this.

Copy link
Member

@humitos humitos Apr 26, 2019

Excellent! 💯

@humitos
Copy link
Member

@humitos humitos commented May 1, 2019

New condition makes sense to me.

@davidfischer davidfischer merged commit 87079ef into master May 10, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/gold-projects-change branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants