Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect project slugs with underscores #5634

Merged
merged 1 commit into from Apr 29, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 25, 2019

This is a PR related to data cleanup. It redirects all requests to /project/<project_slug>/* where project_slug contains an underscore to a version of the project slug with a -.

  • We currently have 7 projects with a _ in them. New projects already can't have an underscore in their slug. We should modify the offending project slugs.
  • Technically, this won't redirect projects with a slug starting or ending with a _ but I think that's ok.

Related to: #5633

@davidfischer davidfischer requested a review from Apr 25, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Probably should have done this the first time. 🤣

@stsewd
Copy link
Member

@stsewd stsewd commented Apr 25, 2019

probably we could add a test with two _ (a_slug_foo)

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 29, 2019

Looks good enough for me. This is legacy code, so we don't need too many tests, it only needs to work for the projects in the past.

@ericholscher ericholscher merged commit 52dbc45 into master Apr 29, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/project-slug-underscore-redirects branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants