Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --upgrade instead of --force-reinstall for pip installs #5635

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@chrisjsewell
Copy link
Contributor

@chrisjsewell chrisjsewell commented Apr 26, 2019

As discussed in #5545, the --force-reinstall causes a lot of issues for Conda builds,
whereby some packages (for example docutils) cannot be uninstalled by pip.

A more comprehensive solution may be to include additional options in the .readthedocs.yaml,
to control the flags used when pip installing.
But, at least as an intermediary solution, I see no drawbacks in using --upgrade --upgrade-strategy eager to achieve the same objective, of ensuring dependencies are up-to-date (but without unnecessary uninstall/reinstall of dependencies).

@stsewd stsewd requested a review from Apr 29, 2019
Copy link
Member

@humitos humitos left a comment

I didn't read the whole thread about the problems.

That said, in case this got merged at some point, it should be under a project feature flag since it has a lot of impact (all projects installing their own package). As we cannot test them all and we had have some random problems on custom projects depending their needings, I prefer to go more defensive here instead.

So, from my perspective we need:

  • wrap this into a feature flag
  • update the docs mentioning this flag
  • maybe, write a user guide explaining in what situations this is needed to activate/request

@stsewd
Copy link
Member

@stsewd stsewd commented May 9, 2019

I'm more at not using pip when using coda as their docs recomend https://www.anaconda.com/using-pip-in-a-conda-environment/ (we need to change our code to install the rtd deps from conda)

@humitos
Copy link
Member

@humitos humitos commented May 9, 2019

I'm not sure, but I think we can't install the package from the repository using conda (is it possible to do conda install . or similar?)

I don't have an strong knowledge on conda and if "just using it" will solve all these issues, but not relying on pip for projects using conda will be a much bigger task. On the other hand, we will need to publish our own extensions to conda-forge as well, not only PyPI.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 6, 2019

This should make conda builds work better, so I'm 👍

@ericholscher ericholscher merged commit 22e85cb into readthedocs:master Jun 6, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants