Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify update docs task #5694

Merged
merged 2 commits into from May 28, 2019
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented May 14, 2019

Currently we have a lot of nested try..exception blocks.
We only need one, we are duplicating the same error handling.

Also, we are already do checks to avoid ending with undefined variables.

I refactored to run run_build after run_setup in the same try...exc block. The exception handling is the same, so it came be removed.

Currently we have a lot of nested try..exception blocks.
We only need one, we are duplicating the same error handling.

Also, we are already do checks to avoid ending with undefined variables.
@stsewd
Copy link
Member Author

@stsewd stsewd commented May 14, 2019

I'm guessing we added the two try..exc blocks because of #5678 but now it's fixed.

@stsewd stsewd requested a review from May 14, 2019
Copy link
Member

@humitos humitos left a comment

Looks simpler, but I think it needs a change to catch exceptions raised in the build environment to be fully compatible with what we had.

readthedocs/projects/tasks.py Show resolved Hide resolved
@stsewd stsewd requested a review from May 14, 2019
Copy link
Member

@humitos humitos left a comment

Look good!

@stsewd stsewd merged commit 3d7d533 into readthedocs:master May 28, 2019
1 check passed
@stsewd stsewd deleted the simplify-update-docs-task branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants