Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent redirect feature added #5727

Merged
merged 2 commits into from Jun 5, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented May 23, 2019

closes #5104

@saadmk11 saadmk11 requested a review from May 23, 2019
Copy link
Member

@humitos humitos left a comment

I like these changes. They allow us to give a custom solution for a particular request without breaking anything and not exposing users with a dangerous redirect.

Users can request a 301 redirect via our support queue and we just need to make a change on those redirects after they set them up and are happy.

@humitos humitos requested a review from May 28, 2019
@humitos
Copy link
Member

@humitos humitos commented May 28, 2019

I'm requesting for another review from the @rtfd/core team to be sure that this is the first step to support this.

Copy link
Member

@ericholscher ericholscher left a comment

Looks good to me. I think we could expose this to users over time, but modeling it is the first step 👍

@ericholscher ericholscher merged commit e31e9fb into readthedocs:master Jun 5, 2019
1 check passed
@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jun 6, 2019

Should we add a migration to change all the existing 301 redirects to 302?

@saadmk11
Copy link
Member Author

@saadmk11 saadmk11 commented Jun 6, 2019

@davidfischer this PR has a migration to change all existing 301 redirects to 302

@saadmk11 saadmk11 deleted the permanent-redirects branch Jun 6, 2019
@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jun 10, 2019

Ahhh, I missed that part of the migration. I saw that there was one migration and I assumed it was auto-generated. However, I now see that changing the default and setting all the ones in the DB is in one migration. Thanks.

@w3guy
Copy link

@w3guy w3guy commented Jun 1, 2021

I want to make the redirects and all future redirects in my project 301. I sent an email and no positive response yet.

When can we get the option to to do this ourselves?

@humitos
Copy link
Member

@humitos humitos commented Jun 1, 2021

@w3guy Hi! I sent you an email yesterday with a question and today I made your redirects 301. Please, keep talking over email. There is no need to comment on a closed PR to ask for support 😃 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants