Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sidebar ad color #5731

Merged
merged 1 commit into from May 30, 2019
Merged

Fix the sidebar ad color #5731

merged 1 commit into from May 30, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented May 24, 2019

  • Using transparency was a mistake especially when the sidebar color can be changed
  • This color is 10% lighter than the default background color on the RTD theme which is what the transparency attempted to accomplish.
  • Fixes: #5563
- Using transparency was a mistake
  especially when the sidebar color can be changed
@davidfischer davidfischer requested a review from May 24, 2019
@davidfischer davidfischer merged commit ae14393 into master May 30, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/sidebar-ad-color-fix branch May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants