Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init.py under readthedocs/api #5742

Merged
merged 1 commit into from May 31, 2019
Merged

Add init.py under readthedocs/api #5742

merged 1 commit into from May 31, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented May 30, 2019

No description provided.

@davidfischer davidfischer requested a review from May 30, 2019
stsewd
stsewd approved these changes May 30, 2019
Copy link
Member

@stsewd stsewd left a comment

Just linking why this was working without __init__.py https://stackoverflow.com/questions/37139786/is-init-py-not-required-for-packages-in-python-3-3

But, I always create it anyway 🤷‍♂️ and fits with the current code base I guess

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented May 30, 2019

This actually was causing some issues on production servers because the __init__.pyc file is still there from before we upgraded.

@ericholscher ericholscher merged commit 776a55c into master May 31, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/api-init-py branch May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants