Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin kombu to 4.3.0 #5747

Merged
merged 2 commits into from May 31, 2019
Merged

Pin kombu to 4.3.0 #5747

merged 2 commits into from May 31, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented May 31, 2019

Celery can install kombu>=4.2.0
https://github.com/celery/celery/blob/v4.1.1/requirements/default.txt#L3

But kombu>4.3.0 requires redis>=3.2
https://github.com/celery/kombu/blob/v4.5.0/requirements/extras/redis.txt#L1

@stsewd
Copy link
Member Author

@stsewd stsewd commented May 31, 2019

You can reproduce this running celery in a fresh installation

@stsewd stsewd merged commit aed5925 into readthedocs:master May 31, 2019
1 check passed
@stsewd stsewd deleted the pin-kombu branch May 31, 2019
@humitos
Copy link
Member

@humitos humitos commented May 31, 2019

This will blow up in production probably. kombu==4.3.x requires a version of redis that it's not compatible with it.

We should pin kombu==4.2.1 which is the version that we have currently installed in production.

@humitos
Copy link
Member

@humitos humitos commented May 31, 2019

In .org production we are using redis 3.2.7

@stsewd
Copy link
Member Author

@stsewd stsewd commented Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants