Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call lock per task #5748

Merged
merged 1 commit into from Jun 4, 2019
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented May 31, 2019

This lock was being shared by sync_repo and build_docs,
I'm moving it to the top of the tasks instead.

This was taken from https://github.com/rtfd/readthedocs.org/pull/5680/files#r284946925
I'm doing this in a separate PR so it's easy to review and this is useful for the whole project

This lock was being shared by sync_repo and build_docs,
I'm moving it to the top of the tasks instead.
@stsewd stsewd requested a review from May 31, 2019
@stsewd stsewd mentioned this pull request Jun 4, 2019
Copy link
Member

@ericholscher ericholscher left a comment

This seems like an obvious improvement. 👍

@ericholscher ericholscher merged commit 92816b0 into readthedocs:master Jun 4, 2019
1 check passed
@stsewd stsewd deleted the remove-one-more-lock branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants