Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain UI improvements #5764

Merged
merged 2 commits into from Jun 5, 2019
Merged

Domain UI improvements #5764

merged 2 commits into from Jun 5, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jun 3, 2019

  • Add a reminder about the exact CNAME value for a domain if the domain is pending
  • Be more explicit in what custom domains do in the domain list view
@davidfischer davidfischer requested a review from Jun 3, 2019
@@ -27,6 +27,9 @@
<strong>{% trans 'SSL certificate status' %}: </strong>
<span>{{ domain.domainssl.status }}</span>
</p>
{% if domain.domainssl.status == 'pending_validation' %}
<p class="help_text"><small>Did you setup a CNAME record in DNS pointing at "readthedocs.io"?</small></p>
Copy link
Member

@stsewd stsewd Jun 3, 2019

missing translation here

stsewd
stsewd approved these changes Jun 3, 2019
@@ -27,6 +27,9 @@
<strong>{% trans 'SSL certificate status' %}: </strong>
<span>{{ domain.domainssl.status }}</span>
</p>
{% if domain.domainssl.status == 'pending_validation' %}
<p class="help_text"><small>{% trans 'Did you setup a CNAME record in DNS pointing at "readthedocs.io"?' %}</small></p>
Copy link
Member

@stsewd stsewd Jun 3, 2019

Shouldn't readthedocs.io get from deafult_domain too?

Doesn't look so importatn anyway.

Copy link
Contributor Author

@davidfischer davidfischer Jun 4, 2019

The CNAME has to be explicitly this value or Cloudflare won't issue the SSL certificate. For deployments other than readthedocs.org, this code path will never be taken because domain.domainssl is in a private repository.

humitos
humitos approved these changes Jun 5, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Looks good 👍

@ericholscher ericholscher merged commit b0379b3 into master Jun 5, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/domain-ui-improvements branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants