Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version_pk to trigger builds #5765

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jun 4, 2019

Currently we are using a mix of project_pk and version_pk.
But we only need a version_pk, the project
can be obtained from the version.

The default version is set at https://github.com/stsewd/readthedocs.org/blob/90211a2828dd874d4209caa4204eec806fdbc431/readthedocs/core/utils/__init__.py#L93-L95

Currently we are using a mix of project_pk and version_pk.
But we only need a version_pk, the project
can be obtained from the version.
@stsewd stsewd mentioned this pull request Jun 4, 2019
@agjohnson agjohnson requested a review from Jun 4, 2019
Copy link
Contributor

@davidfischer davidfischer left a comment

This looks good as far as I can tell and seems to be a bit simpler. I ran through a successful end-to-end build without issue.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Jun 4, 2019

And I just checked the .com site, no changes are needed there.

@stsewd stsewd merged commit de210af into readthedocs:master Jun 4, 2019
1 check passed
@stsewd stsewd deleted the use-version-to-trigger-tasks branch Jun 4, 2019
@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jun 4, 2019

@stsewd Also, if you haven't already, i believe this could require changes in readthedocsinc

@stsewd
Copy link
Member Author

@stsewd stsewd commented Jun 4, 2019

I check, no changes are needed, we call the top-level function only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants