Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on master #5769

Merged
merged 1 commit into from Jun 5, 2019
Merged

Fix tests on master #5769

merged 1 commit into from Jun 5, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jun 5, 2019

Two PRs got merged and one modified the behaviour that the
other one was depending on.

This was giving an error in the lock creation
because the base dir wasn't created yet.

The rest of tests something I forgot to change project_pk -> version_pk
(I did a grep, didn't find more)

Two PRs got merged and one modified the behaviour that the
other one was depending on.

This was giving an error in the lock creation
because the base dir wasn't created yet.

The rest of tests something I forgot to change project_pk -> version_pk
(I did a grep, didn't find more)
@stsewd stsewd requested a review from Jun 5, 2019
@stsewd
Copy link
Member Author

@stsewd stsewd commented Jun 5, 2019

Project's id and version's id are the same here (1), that's why tests didn't fail :)

@ericholscher ericholscher merged commit d0f6dad into readthedocs:master Jun 5, 2019
1 check passed
@stsewd stsewd deleted the fix-tests-master branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants