Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin textclassifier dependencies #5773

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jun 6, 2019

django-textclassifier doesn't have pinned deps
https://github.com/agjohnson/django-textclassifier/blob/v1.0/setup.py

An update in nltk broke the package
nltk/nltk#2312

django-textclassifier doesn't have pinned deps
https://github.com/agjohnson/django-textclassifier/blob/v1.0/setup.py

An update in nltk broke the package
nltk/nltk#2312
Copy link
Member

@saadmk11 saadmk11 left a comment

Tests are fixed now 💯

@stsewd
Copy link
Member Author

@stsewd stsewd commented Jun 6, 2019

So, a fix was released just now https://pypi.org/project/nltk/#history.

But we should pin the dependencies from the other package

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 6, 2019

I'm fine pinning here for now 👍

@ericholscher ericholscher merged commit 9843049 into readthedocs:master Jun 6, 2019
1 check passed
@stsewd stsewd deleted the pin-textclassifier-deps branch Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants