Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate dict when parsing the mkdocs.yml file #5775

Merged
merged 4 commits into from Jun 10, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Jun 7, 2019

closes: #5481

@saadmk11 saadmk11 requested a review from Jun 7, 2019
readthedocs/doc_builder/exceptions.py Outdated Show resolved Hide resolved
readthedocs/doc_builder/exceptions.py Outdated Show resolved Hide resolved
readthedocs/doc_builder/backends/mkdocs.py Outdated Show resolved Hide resolved
saadmk11 and others added 3 commits Jun 8, 2019
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
@saadmk11
Copy link
Member Author

@saadmk11 saadmk11 commented Jun 8, 2019

@stsewd Updated the PR

stsewd
stsewd approved these changes Jun 8, 2019
Copy link
Member

@stsewd stsewd left a comment

Thanks

@ericholscher ericholscher merged commit 45df7fd into readthedocs:master Jun 10, 2019
1 check passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 10, 2019

🎉

@saadmk11 saadmk11 deleted the validate-dict-mkdocs branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants