Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project advertising page/form update #5777

Merged
merged 1 commit into from Jun 18, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jun 7, 2019

  • Remove the forms to contribute to Read the Docs. We don't really get any contributions this way
  • Build value for the commercial product a bit more
  • More prominent get in touch for alternatives
  • Remove mentions of gold. Gold doesn't remove ads from projects anymore. However, projects can get in touch.

Screen Shot 2019-06-07 at 1 54 21 PM

- Remove the forms to contribute to Read the Docs
  We don't really get any contributions this way
- Build value for the commercial product a bit more
- More prominent get in touch for alternatives
- Remove mentions of gold
  Gold doesn't remove ads from projects anymore
@davidfischer davidfischer requested a review from Jun 7, 2019
Copy link
Member

@humitos humitos left a comment

I like the changes. This page looks clearer now.

I suggest to change the gray box/table for the "Opt-Out" section to a regular bullet list.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Jun 10, 2019

I suggest to change the gray box/table for the "Opt-Out" section to a regular bullet list.

Unfortunately our CSS doesn't support bullet lists very well. I am attempting to not write any more custom CSS until our theme work is complete.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Jun 10, 2019

Maybe I can reuse the bullet list above in the page. It requires a special class as just using a <ul> won't have bullets.

@humitos
Copy link
Member

@humitos humitos commented Jun 10, 2019

OK, OK. It's fine as it is. I was just saying because that gray box is not used in any other place as far as I know, and I thought that a bullet list would be easy to add :)

@ericholscher ericholscher merged commit 81b8cf1 into master Jun 18, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/project-ads-page-update branch Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants