Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get version from the api #5788

Merged
merged 1 commit into from Jun 11, 2019
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jun 11, 2019

Don't hit the db

Don't hit the db
Copy link
Member

@ericholscher ericholscher left a comment

Looks good. Another vote for having dev setup operate like prod :)

@ericholscher ericholscher merged commit dc98b58 into readthedocs:master Jun 11, 2019
1 check passed
@stsewd stsewd deleted the get-version-from-api branch Jun 11, 2019
not version.project.has_feature(Feature.CLEAN_AFTER_BUILD)
):
try:
version = SyncRepositoryMixin.get_version(version_pk)
Copy link
Member

@humitos humitos Jun 12, 2019

A comment about why this is not using get_object_or_log as the rest of the functions here would be good to avoid the same confusion in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants