Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging in magic methods #5795

Merged
merged 2 commits into from Jun 12, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jun 12, 2019

Before removing this, we want to collect some info
to communicate this change to users.

Related #5609

Before removing this, we want to collect some info
to communicate this change to users.
Related readthedocs#5609
@stsewd stsewd requested a review from Jun 12, 2019
Copy link
Member

@humitos humitos left a comment

Looks good to me.

It may help us in the future if we add the version.slug as well.

Loading

@stsewd stsewd merged commit 0496f9a into readthedocs:master Jun 12, 2019
1 check passed
Loading
@stsewd stsewd deleted the add-logging-for-magic-methods branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants