Doing if queryset as this does actually evaluates the queryset which can be quite expensive. Rather than doing that, this will just return it. If the project slug is invalid, it should have already 404ed and returning an empty list in the other case seems reasonable. You could see this in the Django Debug Toolbar query tab.
More generally, there is a lot of multi-inheritance in the APIv3 and maybe we could do something to simplify it.
I removed the comment
# NOTE: ``super().get_queryset`` produces the filter by ``NestedViewSetMixin``
In actuality, this method is called by NestedViewSetMixin.get_queryset and not the other way around.
The text was updated successfully, but these errors were encountered:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.