Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable changing domain when editing the object #5816

Merged
merged 2 commits into from Jun 19, 2019
Merged

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jun 17, 2019

When the user clicks on a Domain object to edit it, we don't allow to change the domain field since it does not make sense. In case there was a mistake, the domain needs to be re-created.

@humitos humitos requested a review from Jun 17, 2019
Copy link
Contributor

@agjohnson agjohnson left a comment

LGTM. I don't think there is any reason to not have this in community as well, it seems like a reasonable default.

@humitos humitos merged commit cce9538 into master Jun 19, 2019
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the humitos/disable-domain-edit branch Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants