Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge initial work from Pull Request Builder GSOC #5823

Merged
merged 201 commits into from Jul 19, 2019
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 18, 2019

This is mostly an extension of #5750. It moves all the ongoing and reviewed work from the team into this branch, which is now ready for merging into master when we see fit.

@humitos
Copy link
Member

@humitos humitos commented Jul 15, 2019

I'd like to know how I can test this locally. I tried using ngrok but for some reason PR are not triggered --I may need to do something else with my testing GH app as well.

@saadmk11 can you guide me with the steps I need to do locally?

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Jul 16, 2019

To test This Locally we need to check few things:

  1. Use ngrok to run the local server.
  2. Setup allauth for github and add a test OAuth app on github.
  3. Update the webhook url on github repository to add the url generated by ngrok.
  4. Add ENABLE_EXTERNAL_VERSION_BUILD feature flag to the project.

That should get you up and running 💯

readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jul 19, 2019

Going to merge this to let it simmer in master for a few days, then ship it 🎉

@ericholscher ericholscher merged commit 356d811 into master Jul 19, 2019
1 check passed
Pull Request Builder automation moved this from In progress to Done Jul 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the gsoc-19-pr-builder branch Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants