Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to Build and Version admin #5877

Merged
merged 5 commits into from Jul 11, 2019
Merged

Add config to Build and Version admin #5877

merged 5 commits into from Jul 11, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 2, 2019

This lets us view the configs for debugging. Make it pretty too:

Screenshot 2019-07-02 06 11 33

ericholscher added 2 commits Jul 2, 2019
This lets us view the configs for debugging
@ericholscher ericholscher requested a review from Jul 2, 2019
stsewd
stsewd approved these changes Jul 2, 2019
Copy link
Member

@stsewd stsewd left a comment

Pretty :) I just have one question

response = json.dumps(instance.config, sort_keys=True, indent=2)

# Truncate the data. Alter as needed
response = response[:5000]
Copy link
Member

@stsewd stsewd Jul 2, 2019

Wouldn't this give a syntax error or something when applying the lexer?

Copy link
Member Author

@ericholscher ericholscher Jul 8, 2019

perhaps? I don't think we'll hit this, so we can probably just remove this line.

readthedocs/builds/admin.py Outdated Show resolved Hide resolved
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
@ericholscher ericholscher merged commit 4e8d4db into master Jul 11, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the config-build-admin branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants