Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spaces in email subject link #5891

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jul 8, 2019

Some email clients that aren't gmail apparently don't handle this well as I've gotten a couple emails with the actual subject "Alternatives+to+advertising" instead of "Alternatives to advertising".

@davidfischer davidfischer requested a review from Jul 8, 2019
humitos
humitos approved these changes Jul 8, 2019
Copy link
Member

@humitos humitos left a comment

Looks good to me!

Loading

stsewd
stsewd approved these changes Jul 8, 2019
@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Jul 8, 2019

The lint errors are unrelated. I'm going to merge this.

Loading

@davidfischer davidfischer merged commit a92c21d into master Jul 8, 2019
1 check failed
Loading
@davidfischer davidfischer deleted the davidfischer/fix-email-subject-link branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants