Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for version and project querysets #5894

Merged
merged 2 commits into from Jul 10, 2019

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jul 9, 2019

Related #5872

I could reproduce having duplicates in the project's querysets, but not in the versions' querysets.

You can test this by removing the distinct() call in the querysets. This is only to make sure the other PR doesn't break anything.

@@ -99,7 +99,7 @@ def prefetch_latest_build(self):

# Aliases

def dashboard(self, user=None):
Copy link
Member Author

@stsewd stsewd Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use is never optional here (it gives an error if not user is given)

Loading

@stsewd stsewd requested a review from Jul 9, 2019
@stsewd stsewd merged commit e022b6d into readthedocs:master Jul 10, 2019
1 check passed
Loading
@stsewd stsewd deleted the add-tests-for-querysets branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants