Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda at startup #5897

Merged
merged 1 commit into from Jul 11, 2019
Merged

Update conda at startup #5897

merged 1 commit into from Jul 11, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 9, 2019

Behind a Feature flag, we can decide if we want to update the version of conda from the system to its latest version available.

This allow us to use a new release of conda that is not released under Miniconda yet, but also to not upgrade the Docker image just because of a new release of Miniconda.

(the overhead added is around 60 seconds in total --but they say that the new resolver is way faster... so 馃 )

We can test this for a while under a feature flag, and then we can decide if it worth to enable it by default.

@humitos humitos requested review from ericholscher and Jul 9, 2019
Behind a Feature flag, we can decide if we want to update the version
of ``conda`` from the system to its latest version available.

This allow us to use a new release of ``conda`` that is not released
under Miniconda yet, but also to not upgrade the Docker image just
because of a new release of Miniconda.

(the overhead added is around 60 seconds in total)
@humitos humitos force-pushed the humitos/update-conda-startup branch from 7d5962b to 2efd2d2 Compare Jul 9, 2019
Copy link
Member

@ericholscher ericholscher left a comment

I think we should enable this feature flag to test it, but remove it and just do it in prod if it seems to work well. It feels like a lot of extra work that we should probably not be doing though :/

@humitos
Copy link
Member Author

@humitos humitos commented Jul 9, 2019

@ericholscher I'm not sure to follow you.

Do you say to just remove the feature flag and enable it by default? If it fails, we revert the commit and continue as we were?

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 9, 2019

yes, after we test it with the feature flag.

Copy link
Member

@ericholscher ericholscher left a comment

Let's ship this, then remove the feature flag if it works.

)
shutil.rmtree(version_path)

if self.project.has_feature(Feature.UPDATE_CONDA_STARTUP):
Copy link
Member

@ericholscher ericholscher Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also check if the project is using conda, so we don't run it if the user isn't using conda.

Copy link
Member

@stsewd stsewd Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is under the Conda class, not need to add a check here.

Copy link
Member Author

@humitos humitos Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Santos is right.

stsewd
stsewd approved these changes Jul 11, 2019
@humitos humitos merged commit 02338df into master Jul 11, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the humitos/update-conda-startup branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants