Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for external version in for warning banner #5900



Copy link

@saadmk11 saadmk11 commented Jul 10, 2019

This will add a warning banner to external version docs.

To use this we need to add this in the requirements as its not merged

Sphinx Extension PR: readthedocs/readthedocs-sphinx-ext#72

Screenshot from 2019-07-10 22-54-01

@saadmk11 saadmk11 requested review from ericholscher and Jul 10, 2019
@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Jul 10, 2019
@saadmk11 saadmk11 changed the title add check for external version in Add check for external version in for warning banner Jul 10, 2019
stsewd approved these changes Jul 10, 2019
Copy link

@ericholscher ericholscher left a comment


Copy link

@ericholscher ericholscher commented Jul 10, 2019

Blocking on this until we ship the extension also.

Copy link
Member Author

@saadmk11 saadmk11 commented Jul 17, 2019

The Extension was shipped, so this should not be blocked anymore.

@ericholscher ericholscher merged commit 9c5a756 into readthedocs:gsoc-19-pr-builder Jul 17, 2019
Pull Request Builder automation moved this from In progress to Done Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants