Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the build_pk to the task instead of the build object itself #5904

Merged
merged 2 commits into from Jul 11, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 10, 2019

This breaks in celery when we will ship to prod.

This breaks in celery when we will ship to prod.
@ericholscher ericholscher requested a review from saadmk11 Jul 10, 2019
Copy link
Member

@saadmk11 saadmk11 left a comment

Maybe we just want to pass the version.type. Otherwise, Looks Good 👍

readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
readthedocs/projects/tasks.py Outdated Show resolved Hide resolved
Co-Authored-By: Maksudul Haque <saad.mk11@hotmail.com>
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jul 11, 2019

Yea, we could just send the type along as well. I don't have a strong feeling, but lets merge this so it works, and we can iterate as we go.

@ericholscher ericholscher merged commit 9b23646 into gsoc-19-pr-builder Jul 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the pass-version-github-notifications branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants