Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature Flag to Enable External Version Building #5910

Merged
merged 2 commits into from Jul 11, 2019

Conversation

@saadmk11
Copy link
Member

@saadmk11 saadmk11 commented Jul 11, 2019

No description provided.

@saadmk11 saadmk11 requested review from ericholscher and Jul 11, 2019
@saadmk11 saadmk11 added this to In progress in Pull Request Builder via automation Jul 11, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Looks good with one small change.

# Handle closed pull_request event.
return self.get_delete_external_version_response(self.project)
if self.project.has_feature(Feature.ENABLE_EXTERNAL_VERSION_BUILD):
if event == GITHUB_PULL_REQUEST and action:
Copy link
Member

@ericholscher ericholscher Jul 11, 2019

these can be joined together with an and, instead of a nested if.

Copy link
Member Author

@saadmk11 saadmk11 Jul 11, 2019

Done! :)

@ericholscher ericholscher merged commit b577d63 into readthedocs:gsoc-19-pr-builder Jul 11, 2019
Pull Request Builder automation moved this from In progress to Done Jul 11, 2019
@saadmk11 saadmk11 deleted the feature-flag branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants