Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split APIv3 tests on different files #5911

Merged
merged 6 commits into from Jul 16, 2019
Merged

Split APIv3 tests on different files #5911

merged 6 commits into from Jul 16, 2019

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jul 11, 2019

Just a refactor to easily find the right test easily now that they are growing.

@humitos humitos requested a review from Jul 11, 2019
users=[],
versions=[],
)
# self.translation = fixture.get(Project, slug='translation')
Copy link
Member

@stsewd stsewd Jul 11, 2019

we don't need this I guess

stsewd
stsewd approved these changes Jul 11, 2019
Copy link
Member

@stsewd stsewd left a comment

Just did a quick review, looks good

# self.translation = fixture.get(Project, slug='translation')

self.project.add_subproject(self.subproject)
# self.project.add_translation(self.translation)
Copy link
Member

@stsewd stsewd Jul 11, 2019

and this one

project=self.project,
active=True,
built=True,
type='tag',
Copy link
Member

@stsewd stsewd Jul 11, 2019

It would be better to get this from the readthedocs/projects/constants.py

Copy link
Member

@stsewd stsewd Jul 11, 2019

or builds/constants.py can't remember the exact file

'projects-versions-list',
kwargs={
'parent_lookup_project__slug': self.others_project.slug,
}),
Copy link
Member

@stsewd stsewd Jul 11, 2019

This doesn't match the indentation

@humitos humitos merged commit 39c0b56 into master Jul 16, 2019
1 check passed
@humitos humitos deleted the humitos/apiv3-split-tests branch Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants