Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the GSOC 2019 in-doc search changes #5919

Merged
merged 121 commits into from Jul 16, 2019
Merged

Merge the GSOC 2019 in-doc search changes #5919

merged 121 commits into from Jul 16, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 12, 2019

This merged the feature branch for the GSOC in-doc search project. The goal will be to get it deployed in the next couple weeks, and we'll have a couple more changes coming here, but it should definitely be reviewed by folks before going live.

readthedocs/search/parse_json.py Outdated Show resolved Hide resolved
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jul 16, 2019

I believe this should be unblocked. We probably need to do a staged rollout though to rebuild the indexes. It look a long time last time to rebuild, and we can't ship the new search code before we have a new index because they are not backwards compatible. I will think a bit about the best approach here, but will probably need to take one of the servers out of the LB for this.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jul 16, 2019

Going to merge this once the tests pass 👍

@ericholscher ericholscher merged commit f203884 into master Jul 16, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the gsoc-19-indoc-search branch Jul 16, 2019
@dojutsu-user dojutsu-user moved this from In progress to Done in In-doc search UI Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants