Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count value of docsearch REST api #5926

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jul 15, 2019

Related: #5235

This method works in local but I am not sure that whether this is correct way or not.

@dojutsu-user dojutsu-user requested a review from ericholscher Jul 15, 2019
Copy link
Member

@ericholscher ericholscher left a comment

This looks good. I would like to eventually refactor the entire way we're doing the API, since I think tricking Django into thinking the ES object is a queryset is not a great solution in the long run. This is a good fix for now though.

Loading

@ericholscher ericholscher merged commit 7e112c1 into readthedocs:master Jul 15, 2019
1 check passed
Loading
@dojutsu-user dojutsu-user deleted the results-total-hack branch Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants