Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing between the results and add highlight url param #5932

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Jul 16, 2019

No description provided.

@dojutsu-user dojutsu-user changed the title Fix spacing between the results Fix spacing between the results and add highlight url param Jul 16, 2019
@dojutsu-user dojutsu-user added this to In progress in In-doc search UI via automation Jul 16, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Not 100% sure on this approach. I worry it will make things less configurable by users.

// Also, don't add this spacing in the last hit.
if (j !== inner_hits.length - 1) {
list_item.append($("<div style='margin: 10px 0'></div>"));
}
Copy link
Member

@ericholscher ericholscher Jul 16, 2019

I don't like inline styles here, but it might be necessary since it needs to work across all themes. I feel like we need to make this a classname and have CSS though to make it be user-configurable.

Copy link
Member

@ericholscher ericholscher Jul 16, 2019

We could include a CSS class addition here, which we add to all docs: https://assets.readthedocs.org/static/css/readthedocs-doc-embed.css

Copy link
Member Author

@dojutsu-user dojutsu-user Jul 16, 2019

@ericholscher
I have changed it use a css file and have added css styles in readthedocs-doc-embed.css.

Copy link
Member

@ericholscher ericholscher left a comment

👍

@ericholscher ericholscher merged commit 184cdce into readthedocs:gsoc-19-indoc-search Jul 16, 2019
@dojutsu-user dojutsu-user deleted the fix-spacing-bw-results branch Jul 16, 2019
@dojutsu-user dojutsu-user moved this from In progress to Done in In-doc search UI Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants