Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add READTHEDOCS_LANGUAGE to the environment during builds #5941

Merged
merged 3 commits into from Jul 16, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 16, 2019

This was requested by a user since they can't get it via conf.py,
because we inject our logic after their conf.py data.

This was requested by a user since they can't get it via conf.py,
because we inject our logic after their conf.py data.
@stsewd
Copy link
Member

@stsewd stsewd commented Jul 16, 2019

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jul 16, 2019

Yep, was just working on that :)

stsewd
stsewd approved these changes Jul 16, 2019
Copy link
Member

@stsewd stsewd left a comment

No more ascii char tables :D

@ericholscher ericholscher merged commit ab64918 into master Jul 16, 2019
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the add-language-env-var branch Jul 16, 2019
@akien-mga
Copy link
Contributor

@akien-mga akien-mga commented Jul 17, 2019

Thanks for adding this! I'll test it right away.

No more ascii char tables :D

TIL about the csv-table directive, that's going to be quite useful :D

akien-mga added a commit to godotengine/godot-docs that referenced this issue Jul 17, 2019
Upstream ReadTheDocs added it in readthedocs/readthedocs.org#5941
so that we don't have to define it ourselves.
@akien-mga
Copy link
Contributor

@akien-mga akien-mga commented Jul 18, 2019

Confirmed working after #5951, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants